search

bosnet / sebak

SEBAK, the next BOScoin Blockchain
https://devteam.blockchainos.org
GNU General Public License v3.0
44 stars 15 forks source link

Fix 648: Do not echo back the transaction on successful POST #930

Closed Geod24 closed 5 years ago

Geod24 commented 5 years ago

It is a waste of resources and does not provide any information to the client.

codecov-io commented 5 years ago

Codecov Report

Merging #930 into master will increase coverage by 0.15%. The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   60.85%   61.01%   +0.15%     
==========================================
  Files         160      159       -1     
  Lines       11254    11239      -15     
==========================================
+ Hits         6849     6857       +8     
+ Misses       3604     3575      -29     
- Partials      801      807       +6
Flag Coverage Δ
#integration_tests_long_term 43.97% <20%> (+0.15%) :arrow_up:
#integration_tests_node 41.06% <30%> (+0.55%) :arrow_up:
#integration_tests_retry 37.72% <0%> (+0.05%) :arrow_up:
#unittests 47.4% <0%> (+0.07%) :arrow_up:
Impacted Files Coverage Δ
lib/client/client.go 3.36% <0%> (-0.03%) :arrow_down:
lib/node/runner/api/transaction_post.go 38.88% <100%> (+3.88%) :arrow_up:
lib/network/httputils/json.go 53.84% <0%> (-3.85%) :arrow_down:
lib/node/runner/checker.go 73.61% <0%> (+0.21%) :arrow_up:
lib/node/runner/finish_ballot.go 45.28% <0%> (+1.41%) :arrow_up:
lib/node/runner/util.go 75% <0%> (+3.57%) :arrow_up:
lib/block/transaction_pool.go 56.6% <0%> (+3.77%) :arrow_up:
lib/node/runner/node_api/api_node_item.go 64.1% <0%> (+10.25%) :arrow_up:
lib/network/http2_client.go 67.01% <0%> (+10.3%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4d883e...ca04bfb. Read the comment docs.