search

boson-project / buildpacks

Boson Project function buildpacks
Apache License 2.0
5 stars 11 forks source link

refactor: remove func.yaml from all run images #105

Closed lance closed 3 years ago

lance commented 3 years ago

This commit removes all instances of func.yaml from a built image. In doing this, I also refactored the Node.js buildpack so that the app is no longer running from the /workspace build directory. Instead, it's run from a layer at /layers/app.

Fixes: https://github.com/boson-project/buildpacks/issues/87

Signed-off-by: Lance Ball lball@redhat.com

matejvasek commented 3 years ago

you must chmod u+w -R $build_dir before deleting EDIT: at least for golang

matejvasek commented 3 years ago

I find it really weird that buildpacks include $build_dir in run image, IMHO it shouldn't.

lance commented 3 years ago

I find it really weird that buildpacks include $build_dir in run image, IMHO it shouldn't.

Agree!

lance commented 3 years ago

@matejvasek I've made some changes, so the behavior is consistent across all buildpacks. ptal

matejvasek commented 3 years ago

LGTM @lance have you tried it against func templates?

lance commented 3 years ago

LGTM @lance have you tried it against func templates?

Yes - I ran it against https://gist.github.com/lance/b54dd596564106e079530f55cce42548

zroubalik commented 3 years ago

LGTM @lance have you tried it against func templates?

Yes - I ran it against https://gist.github.com/lance/b54dd596564106e079530f55cce42548

@lance can we add something like this into the CI?

lance commented 3 years ago

LGTM @lance have you tried it against func templates?

Yes - I ran it against https://gist.github.com/lance/b54dd596564106e079530f55cce42548

@lance can we add something like this into the CI?

I was going to add that script to the PR last week but @matejvasek is working on something better here https://github.com/boson-project/buildpacks/pull/106