search

bosondata / chrome-prerender

Render JavaScript-rendered page as HTML/PDF/mhtml/png/jpeg using Headless Chrome
MIT License
165 stars 20 forks source link

S3 path fix #24

Closed Nyoroon closed 6 years ago

Nyoroon commented 6 years ago

There is no need in hash functions to distribute across subdirs, just use urlencode for readability. Resolves #23

messense commented 6 years ago

I am not sure whether S3 have any limitations on object names. I'll need to check that, if you have any information please post it here, thanks!

Nyoroon commented 6 years ago

S3 is actually Key/Value storage (and original prerender doesn't use any encoding or hash for urls, just puts as is), so it's okay to use almost anything. https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html