bosonprotocol / contracts

[DEPRECATED] Boson Protocol v1
GNU Lesser General Public License v3.0
69 stars 17 forks source link

Unable to run tests due to node versioning #56

Closed RichardLitt closed 3 years ago

RichardLitt commented 3 years ago

The install docs say that I am good down to Node 10.23. However, I'm getting this issue when running it:

➜  contracts git:(master) ✗ nvm ls
       v10.19.0
       v11.14.0
->     v12.20.2
       v13.10.1
         system
default -> v13 (-> v13.10.1)
node -> stable (-> v13.10.1) (default)
stable -> 13.10 (-> v13.10.1) (default)
iojs -> iojs- (-> system) (default)
lts/* -> lts/fermium (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.23.3 (-> N/A)
lts/erbium -> v12.20.2
lts/fermium -> v14.15.5 (-> N/A)
➜  contracts git:(master) ✗ ./go tests:unit
Configuring NVM if present.
Checking for system dependencies.
This codebase requires Node 12.20
Please install missing dependencies to continue.

I downgraded to v12.20 from v13.10, and I am still getting the error that it requires Node 12.20.

tobyclemson commented 3 years ago

Hey Richard,

What shell are you using? Can you share the relevant contents of .bashrc, .bash_profile, .zshrc?

Thanks, Toby

RichardLitt commented 3 years ago

I'm using zshrc on OSX. The only line that mentions node is plugins=(git nvm node python pip), that I can tell.

tobyclemson commented 3 years ago

Hmm ok, the nvm plugin for zsh is doing quite a lot: https://github.com/ohmyzsh/ohmyzsh/blob/master/plugins/nvm/nvm.plugin.zsh, hopefully the right "stuff" though.

Does node --version correlate with what nvm ls is telling you?

RichardLitt commented 3 years ago

Yeah, I was worried about that. But they are the same:

➜  ~ nvm ls
       v10.19.0
       v11.14.0
       v12.20.2
->     v13.10.1
         system
default -> v13 (-> v13.10.1)
node -> stable (-> v13.10.1) (default)
stable -> 13.10 (-> v13.10.1) (default)
iojs -> iojs- (-> system) (default)
lts/* -> lts/fermium (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.23.3 (-> N/A)
lts/erbium -> v12.20.2
lts/fermium -> v14.15.5 (-> N/A)
➜  ~ node --version
v13.10.1
➜  ~ nvm use v12.20.2
Now using node v12.20.2 (npm v6.14.11)
➜  ~ nvm ls
       v10.19.0
       v11.14.0
->     v12.20.2
       v13.10.1
         system
default -> v13 (-> v13.10.1)
node -> stable (-> v13.10.1) (default)
nstable -> 13.10 (-> v13.10.1) (default)
vm iojs -> iojs- (-> system) (default)
lts/* -> lts/fermium (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.23.3 (-> N/A)
lts/erbium -> v12.20.2
lts/fermium -> v14.15.5 (-> N/A)
➜  ~ node --version
v12.20.2
➜  ~
RichardLitt commented 3 years ago

Same problem on the bosonprotocol/token-contracts repository.