search

bosonprotocol / contracts

[DEPRECATED] Boson Protocol v1
GNU Lesser General Public License v3.0
69 stars 17 forks source link

Check value of ERC-20 transfers in BosonRouter #81

Closed thecryptofruit closed 3 years ago

thecryptofruit commented 3 years ago

Minor volatile code issue: BosonRouter.sol is not checking for return value of transfer() and transferFrom() of the ERC-20. Reason: the contract has reached max size and needs refactoring.

Recommendation: user OpenZeppelin's SafeERC20.sol.

mischat commented 3 years ago

We will be looking at this internally, before making the public release of v0.2

hswopeams commented 3 years ago

Implemented in https://github.com/bosonprotocol/contracts/pull/149