search

bosonprotocol / widgets

Widgets to interact with Boson Protocol
Apache License 2.0
6 stars 0 forks source link

reconsider use of email or XMTP preference for the redemption info #114

Closed levalleux-ludo closed 9 months ago

levalleux-ludo commented 9 months ago

At the moment, the redeem widget code suggests the email to be required only when the contact preference of the seller is set to "xmtp_and_email". If the contact preference is "xmtp", the email is asked but not required.

However, the current implementation fails in doing that in most case. The following PR https://github.com/bosonprotocol/core-components/pull/642 forces the email to be always required.

This issue is opened to raise that point and reconsider whether or not we want to achieve the initially expected behaviour

levalleux-ludo commented 9 months ago

Rework of the PR https://github.com/bosonprotocol/core-components/pull/642 now keeps the original behaviour, fixing the issue

sukrita3 commented 8 months ago

Not sure what was changed here, as I am still always asked for email in the redemption form.