bossadvisors / memcached-session-manager

Automatically exported from code.google.com/p/memcached-session-manager
0 stars 0 forks source link

Add possibility to disable msm at runtime #60

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It should be possible to disable msm at runtime, e.g. via jmx.

Original issue reported on code.google.com by martin.grotzke on 4 Sep 2010 at 8:07

GoogleCodeExporter commented 9 years ago
Implemented. There's a new "enabled" property that can be set in the manager 
configuration, it's also accessible via jxm.

In disabled mode, sessions are not looked up in memcached and not stored in 
memcached, the SessionTrackerValue is just passing requests to the next valve 
(for prócessing the request) without doing anything further.

Original comment by martin.grotzke on 4 Sep 2010 at 8:57

GoogleCodeExporter commented 9 years ago
This broke a test.   Here is a patch.

Original comment by pgweiss....@gmail.com on 21 Oct 2010 at 2:55

Attachments:

GoogleCodeExporter commented 9 years ago
When starting disabled by setting <Manager ... enabled="false" .. /> it still 
creates a memcached client.  This causes annoying logging when the server is 
unavailable.  I suggest that the client only be run when enabled=true.  This 
patch suppresses client creation when enabled=false at startup.  ( Ideally the 
client should be brought up or down depending on the state of the enabled flag. 
)

Original comment by pgweiss....@gmail.com on 21 Oct 2010 at 3:03

Attachments:

GoogleCodeExporter commented 9 years ago
Thanx, patches applied. The memcached client now is also created/destroyed when 
the msm enabled status is changed at runtime (via jmx). Also added tests.

Original comment by martin.grotzke on 21 Oct 2010 at 10:38

GoogleCodeExporter commented 9 years ago

Original comment by martin.grotzke on 27 Jan 2011 at 10:36