collection_image_url sometimes returns invalid IIIF image URL

boston-library / commonwealth-vlr-engine

Commonwealth-VLR-Engine is a Rails engine for creating Blacklight apps that provide access to content from Solr/Fedora, packaging a number of feature-rich enhancements and modifications.

Apache License 2.0

8 stars 2 forks source link

collection_image_url sometimes returns invalid IIIF image URL #16

Closed ebenenglish closed 3 years ago

ebenenglish commented 3 years ago

In some cases, the CollectionHelperBehavior#collection_image_url method returns an invalid region that causes the resulting IIIF image URL to be invalid, which leads the image server to throw a 400 error.

Example image pid: commonwealth:7h14cx91v

Returns this URL: https://iiif.digitalcommonwealth.org/iiif/2/commonwealth:7h14cx91v/-221,0,7209,2949/1100,/0/default.jpg

Image server error message:

400 Bad Request
X must be a positive float

ebenenglish commented 3 years ago

Fixed via https://github.com/boston-library/commonwealth-vlr-engine/commit/362f48363f7a3fb8ea0bb15da67c96e73846f72a