bostrot / wsl2-distro-manager

A GUI to quickly manage your WSL2 instances
https://apps.microsoft.com/store/detail/wsl-manager/9NWS9K95NMJB
Other
1.82k stars 111 forks source link

[BUG] Change the Default Distro Location not working #200

Closed joutvhu closed 10 months ago

joutvhu commented 1 year ago

Is there an existing issue for this?

Current Behavior

I have changed the Default Distro Location to F:\ProgramData\WSL2-Distros image

However when I use Open with File Explorer or Move to default location it use path C:\WSL2-Distros image image

Expected Behavior

Steps To Reproduce

  1. Settings > change Default Distro Location
  2. Home > select a distribution > click Open in File Explorer

Environment

- Windows Version: 11 
- WSL Distro Manager Version: 1.8.5
- WSL Version: 2
- Source: 1.8.5

Anything else?

No response

github-actions[bot] commented 1 year ago

Hello there! As you are a first time Issuer please read our Code of Conduct. Please also check whether your issue description is reasonable and complete. If you are having an issue always include the version you are using (WSL, this app, Windows) as well as a way to reproduce it.

HadiJadallah commented 1 year ago

Yes, its an annoying bug. Stumbled upon it while freeing up some space from my C drive.

joutvhu commented 1 year ago

Hi @bostrot, This error was caused by DistroPath not being set. I fixed it in the following pull request https://github.com/bostrot/wsl2-distro-manager/pull/209 Please help to review the pull request

Rakly3 commented 11 months ago

Now it simply crashes the distro manager when changing the volume path.

joutvhu commented 11 months ago

The application crashed by the FilePicker.platform.getDirectoryPath method. I've seen it before. If you change the path by selecting, the application will exit. If you change the path by typing, no error will appear. Looks like it comes from the file_picker library.