search

bosun-monitor / bosun

Time Series Alerting Framework
http://bosun.org
MIT License
3.4k stars 494 forks source link

Duration timings should use a monotonic clock. #1857

Closed gbrayut closed 4 years ago

gbrayut commented 8 years ago

Our scollector and collect duration timings are probably being effected by using time.Time which is not monotonic and can be effected by changes to the system time (manual or automated by NTP). Not a huge deal, but likely causes incorrect data in the duration metrics.

Access to a monotonic clock is slated for go 1.8, but there are also packages like goarista and monotime. We could also use it as an opportunity to switch these metrics to use atomic operations instead of locks.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.