bosun-monitor / bosun

Time Series Alerting Framework

http://bosun.org

MIT License

3.4k stars 495 forks source link

Add ElasticSearch 7.x support #2440

Closed harudark closed 4 years ago

harudark commented 4 years ago

Description

This pull request adds ES 7.x support in Bosun. I submitted https://github.com/bosun-monitor/bosun/pull/2427 before but that is based on my own go modules migration pull request which is different from what upstream maintainers did. This one is based on upstream go modules migration.

https://github.com/olivere/elastic/ version 7 client is used.
Most code are copy-pasted from ES version 6 support.
The one difference is in ES 7 mapping types is removed, Type(docType) are removed in ES7

Type of change

From the following, please check the options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How has this been tested?

Tested with ES 7.2 and also ES 6.8 to make sure nothing breaks.

update the configuration toml file and create some alerts to query ES
verify alerts can be triggered and no errors in ES query
verify annotate can work

Checklist:

[x] This contribution follows the project's code of conduct
[x] This contribution follows the project's contributing guidelines
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

svagner commented 4 years ago

@harudark Should we close MRs https://github.com/bosun-monitor/bosun/pull/2426, https://github.com/bosun-monitor/bosun/pull/2427 and https://github.com/bosun-monitor/bosun/pull/2442 then?

harudark commented 4 years ago

@harudark Should we close MRs #2426, #2427 and #2442 then?

I'll fix issues mentioned in code review and then close those MRs.

langerma commented 4 years ago

any news on that?

johnewing1 commented 4 years ago

@svagner @harudark Have you had a chance to make the last few changes to this ?