Fix TestNewManager

[svagner]

Please follow the guide below

Description

Fix test TestNewManager Use only full hostname for tests (see os.Hostname())

Fixes #2460

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How has this been tested?

• [x] TestNewManager

Checklist:

• [x] This contribution follows the project's code of conduct
• [x] This contribution follows the project's contributing guidelines
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules

[tdinucci]

Yes, thanks for the PR 👍

I think we probably need two tests actually:

• One where preserveFullHostName == true
• One where preserveFullHostName == false but this test must then split the copy of expectedHostname in the test on the first . (which the current test isn't doing).

If you would like to update your PR to cover both of these scenarios that would be great. Otherwise I'll be happy to do this.

[tdinucci]

Once you bring your branch inline with master we should be able to merge

[svagner]

Thanks @tdinucci ! Branch was updated:)