Closed ledouxm closed 11 months ago
No need to add the .json files in the PR
do you want the en and fr ones or i delete them too ?
Nothing in data/
must be manually commited. Checkout *.json please
So everytime you push something you have to delete the json files populated by the github action ?
So everytime you push something you have to delete the json files populated by the github action ?
No, its a mistake I've made... By delete, I mean checkout the *.json to the previous commit so that it does not appear in the PR. I tried to do it on the UI but with no success...
ok i've rollbacked them, it feels weird having json files not matching the ones generated by the code tho
do you plan on merging this PR ? if it doesnt fit your needs, tell me what to change
@ledouxm A tricky thing append while removing a branch: This issue has been automatically closed and I cannot reopen it. You will have to PR on master
again...
This is a copy of this closed PR since i had some issues with the fork...
This is the original description for context:
Hi, i also developped a tool that does pretty much the same but i think having a single repo which we rely on could be a great thing for the ecosystem.
Sadly, as this issue states, the events.json file isn't complete enough to read a message.
This PR aims to fix this by adding two new types along with Vector :
I can clarify any point if needed !