search

botblock / BotBlock.org

BotBlock - The List of Discord Bot Lists and Services
https://botblock.org/
Mozilla Public License 2.0
28 stars 8 forks source link

Add eslint config & test #25

Closed VivekSingh777 closed 4 years ago

VivekSingh777 commented 4 years ago

@MattIPv4 Added eslint support

VivekSingh777 commented 4 years ago

Screenshot 2019-10-09 at 4 10 06 AM @MattIPv4 Did I need to fix all lint errors?

MattIPv4 commented 4 years ago

No, don’t worry about fixing the errors, that can be a separate issue once this is merged — However, is there a config change that can be made to resolve window & document being undefined being treated as an issue?

VivekSingh777 commented 4 years ago

No, don’t worry about fixing the errors, that can be a separate issue once this is merged — However, is there a config change that can be made to resolve window & document being undefined being treated as an issue?

  1. Indentation in the config file is inconsistent.
  2. Can we use strings for off/warn/error instead of their integer counterparts?
  3. Can eslint also be integrated into the mocha test suite, please?

@MattIPv4 Done

VivekSingh777 commented 4 years ago

@MattIPv4 Done changes and integrated eslint to mocha

MattIPv4 commented 4 years ago

If this was integrated into the mocha test suite, should the CI have failed as there are outstanding eslint issues with the project?

MattIPv4 commented 4 years ago

Oops.

VivekSingh777 commented 4 years ago

If this was integrated into the mocha test suite, should the CI have failed as there are outstanding eslint issues with the project?

I don't get it?

MattIPv4 commented 4 years ago

The CI runs npm test which is the full mocha test suite, located in the /test directory. The eslint checks should be added so that they run as part of the mocha test suite, please :)

I can help with this in the morning if you’re stuck or unsure.

VivekSingh777 commented 4 years ago

Cool will take this up in morning.

VivekSingh777 commented 4 years ago

The CI runs npm test which is the full mocha test suite, located in the /test directory. The eslint checks should be added so that they run as part of the mocha test suite, please :)

I can help with this in the morning if you’re stuck or unsure.

Can u help me about your comment. I have integrated eslint with mocha. Here is the screenshot for the same. Screenshot 2019-10-09 at 11 32 35 AM @MattIPv4

MattIPv4 commented 4 years ago

CI failure expected.