Closed cheesycod closed 3 years ago
I don't see why we're changing the default values here, but I do see a few reasons for not:
Using 0000 as discriminator may not immediately obvious
. No bot can have 0000, so it is incredibly obvious.That being said, I appreciate the updates to the actual logic for parsing data from lists.
Yeah, it should probably stay an empty string then
@MattIPv4 maybe instead of doing this sort of parsing, it might be better to ask bot lists what keys they use and use that so u directly know what keys u need
I don't really think its viable or scaleable to try tracking all the potential fields from every list that we need to parse. Just having robust parsing logic that attempts to find everything is far easier, especially as not only the field names but also the data structures can vary.
You've still got some breaking changes in the defaults returned by the API which I'd like reverted please, there isn't reason to change the defaults.
Fixed
This might be a bad PR but I feel this makes the API a bit easier to use as you can quickly see that’s it’s null. Using 0000 as discriminator may not immediately obvious