search

botdad / chain-claim

Claim code generation and on chain verification using EIP-712 instead of merkle proofs
MIT License
51 stars 2 forks source link

ISSUER cannot be transferred #1

Open TimDaub opened 2 years ago

TimDaub commented 2 years ago

I have a situation where potentially a user's keys can get compromised and we'd e.g. have to rotate addresses. But unfortunately, the ISSUER is currently immutable.

However, with https://eips.ethereum.org/EIPS/eip-173, we'll soon have a usable canonical ownership standard. So it'd actually be pretty awesome to just replace the ISSUER with e.g. OZ's Ownable .owner().

@botdad, is this something you're interested in having implemented in this library? I'd send a PR!

rahulrumalla commented 2 years ago

Making this ownable would or to support a way to transfer ownership i.e., ISSUER would be great and provide a ton of flexibility to devs.

botdad commented 2 years ago

I messaged @rahulrumalla on twitter but it might be easier since the conversation is already going here.

I'm not actively maintaining this codebase and so far everything you all have suggested seems useful and in line with the initial goals of the project. Instead of me being a gatekeeper for merging would you have interest in the @otterspace-xyz being the active fork? I'd update the repo here to state that in the readme

TimDaub commented 2 years ago

Sounds reasonable and @rahulrumalla would probably be happy about it. Not sure I have the cryptography skills of handling some issues. Are you available for questions @botdad

TimDaub commented 2 years ago

sorry accidentially closed

rahulrumalla commented 2 years ago

Yes, would be keen to @botdad Left you a DM to discuss a short handover session.

TimDaub commented 2 years ago

btw what has worked in the past too is that we at otterspace remove the fork link on Github by contacting support and botdad just archives and points to us in the readme.

But transferring the repo is probably better as GH then automatically does a 301 redirect when accessing botdad's.

botdad commented 2 years ago

Yeah, either way is fine with me. Let me know what ya'll prefer.