search

botfront / rasa-addons

A set of 🚀🚀🚀 components to be used with Botfront and/or Rasa
https://botfront.io
Apache License 2.0
131 stars 37 forks source link

Support for version 0.10.x #4

Closed PierrePaul closed 6 years ago

PierrePaul commented 6 years ago

A new parameter has been added to rasa core Agent __init__ function, generator. It has been added right before the old tracker_store argument, so it breaks when rasa-addons sends the tracker as a generator to the base Agent class. Specifying the arguments from rasa-addons when creating the base class fixes the issue.

We might want to create a generator ourselves and send it to the base class, but Im leaving that to someone who knows more about the generators.

PierrePaul commented 6 years ago

0.10.0, 0.10.1 and 0.10.2 have been released since Ive opened this merge request. Seems like it's breaking in more ways now than before (0.10a4).

PierrePaul commented 6 years ago

I've updated the merge request to work with any version > 0.10.x. This brings backward incompatible changes. I'm not sure how you want to release/merge this.