search

botify-labs / python-simple-workflow

DISCONTINUED - See README
http://python-simple-workflow.readthedocs.org/
MIT License
18 stars 4 forks source link

Winter refactoring #53

Closed jbbarth closed 8 years ago

jbbarth commented 8 years ago

See botify-labs/simpleflow#76. WIP, do not merge.

I'm just opening the PR now so that Travis builds this along the way.

jbbarth commented 8 years ago

Ready to merge if you want to review, ping @ybastide @ampelmann @benjastudio

Mostly cosmetic changes except the addition of a Decider.poll_for_task() method, that returns a response object containing workflow execution informations. See botify-labs/simpleflow#76 for why it's useful.

I'll open a new issue here so we consider merging the 2 projects for easier management.

ybastide commented 8 years ago

Perhaps a flake8 pass? :-) (with

[flake8]
max-line-length = 120

in setup.cfg, obviously)

Other than that: :+1:

jbbarth commented 8 years ago

Yes for flake8, no pb! For now I don't run flake8 on this project but it would be a good idea, obviously. I'll add that and merge this, thanks!!

ampelmann commented 8 years ago

:+1:

benjastudio commented 8 years ago

:+1: