Remove explicit handling of AWS credentials from env vars.

botify-labs / simpleflow

Python library for dataflow programming.

https://botify-labs.github.com/simpleflow/

MIT License

68 stars 24 forks source link

Remove explicit handling of AWS credentials from env vars. #347

Closed mookerji closed 5 years ago

mookerji commented 6 years ago

Removes explicit handling of AWS keys from the environment, which is handled by boto2's credentials provider by default. This will also allow AWS_SECURITY_TOKEN to be handled correctly, which is broken in the boto2 v2.49 SWF Layer1 client.

Closes https://github.com/botify-labs/simpleflow/issues/346.

mookerji commented 6 years ago

I'm hoping these are minimal changes that are backwards compatible with your environment. AWS_DEFAULT_REGION is not an env var that exists in boto2, so I've left that in. Please, let me know if there are any other changes I should make.

Also, looks like this Travis test is flaky, but haven't looked much into it: https://travis-ci.org/botify-labs/simpleflow/jobs/426526153#L1010

jbbarth commented 6 years ago

@mookerji thanks, the changes look good at first sight! I'll test them in our environment and confirm here. Also @ybastide if you want to have a look that would be great ;-)

As for the flaky test: yes, it's terrible :/ we try to test the process handling with time based assertions where we basically "sleep" a moment and see if changes are what we expect. I'll look into it, I think we have a decorator for marking those tests so they don't fail the build.

ybastide commented 5 years ago

Sorry—forgot merging ...