botify-labs / simpleflow

Python library for dataflow programming.
https://botify-labs.github.com/simpleflow/
MIT License
68 stars 24 forks source link

implement influxdb instrumentation #369

Closed Gnoale closed 4 years ago

Gnoale commented 4 years ago

Description

See comments from this issue for details about the implementation choice of InfluxDB.

I looked for the 2 endpoints referred in the issue 298 RecordActivityTaskHeartbeat and PollForActivityTask, and implement a method inside swf/core.py to send statistic to InfluxDB.

I defined the tags region endpoint and hostname.

Considerations for Reviewers

The UDP listener on InfluxDB server doesn't seems to support this, a solutions could consist in writing to a Telegraf proxy agent wich would send the data to Influx over HTTPS. Or use a local database in the same network.

jbbarth commented 4 years ago

No need for this in the end, should be close by a repo admin (I can't)