botify-labs / simpleflow

Python library for dataflow programming.
https://botify-labs.github.com/simpleflow/
MIT License
68 stars 24 forks source link

TaskFailureContext: add full exception class name #375

Closed ybastide closed 3 years ago

ybastide commented 4 years ago

We currently have an optional task_error available for failed activities. This is the exception class name. However, if the exception is not built-in, its module is missing: a boto EC2 exception will be EC2ResponseError instead of boto.exception.EC2ResponseError.

Let's provide the full path, for disambiguation and isinstance checking.

ybastide commented 3 years ago

Done: https://github.com/botify-labs/simpleflow/pull/377