Open jbbarth opened 11 months ago
See https://github.com/botify-labs/simpleflow/blob/main/pyproject.toml#L86C2-L88 and https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html . We're missing tool.setuptools.packages.find
and the find directive
Thanks @ewjoachim I just saw exactly that!
For posterity:
pip uninstall -y simpleflow; pip install git+https://github.com/botify-labs/simpleflow.git@1e755cea0693f55dcc1013a3235507c88df79e39
=> same result)pip uninstall -y simpleflow; pip install --verbose ../../botify-labs/simpleflow
=> makes it easy to testfind = {}
worksI'll check everything twice and submit a PR this morning
Oopsie—I've been bitten by this a few times but didn't investigate it; thank you both!
The issue is that as soon as I include all sub directories correctly, I get "build", "examples", "venv" and "tests" installed into my site-packages. The "exclude" directive doesn't seem to work, at least not as documented. I'm digging more. Send help if you don't hear about me in 2 days.
@ybastide @ewjoachim I randomly stumbled upon Hatch via Stackoverflow, and it works nicely out of the box. I'm tempted to dig into that direction, and in particular check if it has any impact on "script/release". Any opinion on the topic?
Looks like it would simplify script/release
bigly 🙂
Joachim has a lot of experience in such subjects, I'll defer to both of you.
Not a huge fan of hatch compared to poetry (both are equivalent tools) but it's true that hatch, being born later, uses the standard PEP-defined format for pyproject.toml while poetry uses its own format.
Honnestly, I'm ok with both. Let's go with hatch, this way I'll learn.
Alternatively we can keep setuptools if we find a config that works (== that doesn't leak "examples" in my site-packages 😆)
About poetry: I'm using it daily and I absolutely hate it. It failed us so many times (not in the context of a lib though). I'd be very happy to discuss this with you over a beer one day!
👎 on keeping setuptools, we all want to learn 🙂
@ybastide @ewjoachim I tested hatch a bit more and submitted a PR here => #435. Lmk what you think, no hurry!
Problem:
results in:
We're missing all the subdirectories.
Versions in case it matters:
I'm digging