search

botify-labs / simpleflow

Python library for dataflow programming.
https://botify-labs.github.com/simpleflow/
MIT License
68 stars 24 forks source link

Build with build #437

Closed ybastide closed 1 month ago

ybastide commented 2 months ago

A few small fixes, typing, ruff update, and deletion of setup.py.

ewjoachim commented 2 months ago

I'm In favor of multiple small PRs and we'll do a release when we're all good, so let's merge asap.

ewjoachim commented 2 months ago

Also, you didn't add configuration for Ruff yet. Here is a personal example: https://github.com/procrastinate-org/procrastinate/blob/main/pyproject.toml#L139-L159 You may also want those: https://github.com/py-cov-action/python-coverage-comment-action/blob/main/pyproject.toml#L62-L64

ybastide commented 2 months ago

I'm In favor of multiple small PRs and we'll do a release when we're all good, so let's merge asap.

I had to update the PR as it didn't pass the CI with the new ruff version (more so with the pyproject improvements)