search

botman / docs

BotMan documentation
33 stars 52 forks source link

Explain command to register Telegram webhook #44

Closed Jeroen-G closed 6 years ago

Jeroen-G commented 6 years ago

There's no need to hide the existence of the command 😄

mpociot commented 6 years ago

Thank you!

christophrumpel commented 6 years ago

I think we should try to keep php artisan driver commands as similar as possible. There are already some for FB and they use another standard for the naming (botman:facebookAddGreetingText , botman:facebookAddStartButton) We should stick to one convention. Maybe the one with botman:driver:command is fine.

mpociot commented 6 years ago

Yeah I like the botman:driver convention Christoph Rumpel notifications@github.com schrieb am Mo. 9. Okt. 2017 um 18:46:

I think we should try to keep php artisan driver commands as similar as possible. There are already some for FB and they use another standard for the naming (botman:facebookAddGreetingText , botman:facebookAddStartButton) We should stick to one convention. Maybe the one with botman:driver:command is fine.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/botman/docs/pull/44#issuecomment-335214639, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxHTL2bkIIwSAqrP-cfVkmTS2SmPEOGks5sqk3YgaJpZM4Pyiu- .

-- Marcel Pociot

http://www.marcelpociot.com https://github.com/mpociot http://twitter.com/marcelpociot

Jeroen-G commented 6 years ago

That might be as easy as adding a : in there ^_^ I'll get a PR going.

christophrumpel commented 6 years ago

You mean botman:driver:command @mpociot ? Yeah @Jeroen-G , it is more work to talk about it :-)