search

botman / driver-botframework

BotMan Microsoft Bot Framework Driver
MIT License
9 stars 12 forks source link

fix for removing botname from received text #17

Open eldiaboloz opened 4 years ago

eldiaboloz commented 4 years ago

In Bot Framework SDK v4 and skype groupchat at least "channelData->text" holds the raw message and is escaped correclty "text" is already filtered, but still contains @ botname so can not be used

Probably will fix #13 and #10

codecov[bot] commented 4 years ago

Codecov Report

Merging #17 into master will increase coverage by 0.23%. The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #17      +/-   ##
============================================
+ Coverage     55.24%   55.47%   +0.23%     
- Complexity       42       43       +1     
============================================
  Files             4        4              
  Lines           143      146       +3     
============================================
+ Hits             79       81       +2     
- Misses           64       65       +1
Impacted Files Coverage Δ Complexity Δ
src/BotFrameworkDriver.php 75.55% <75%> (-0.31%) 26 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c3fc24...9af73f4. Read the comment docs.