search

botman / driver-botframework

BotMan Microsoft Bot Framework Driver
MIT License
9 stars 12 forks source link

Fix user id for group chat. #8

Open maalls opened 6 years ago

maalls commented 6 years ago

I am suggesting to use getSender() instead of getRecipient() to set the user ID because getSender() will always have the user ID while getRecipient() has the conversation ID in case of group chat.

codecov[bot] commented 6 years ago

Codecov Report

Merging #8 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage     55.24%   55.24%           
  Complexity       42       42           
=========================================
  Files             4        4           
  Lines           143      143           
=========================================
  Hits             79       79           
  Misses           64       64
Impacted Files Coverage Δ Complexity Δ
src/BotFrameworkDriver.php 75.86% <100%> (ø) 25 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c3fc24...9748f69. Read the comment docs.