botman / driver-facebook

BotMan Facebook Messenger Driver
MIT License
71 stars 72 forks source link

Update type drivers for type key exists checks #55

Closed richdynamix closed 6 years ago

richdynamix commented 6 years ago

Due to lack of checks of the existence of the type key within the matchesRequest() method of each child driver type we get similar errors to the following -

local.ERROR: Undefined index: type {"exception":"[object] (ErrorException(code: 0): Undefined index: type at /app/vendor/botman/driver-facebook/src/FacebookFileDriver.php:24)
local.ERROR: Undefined index: type {"exception":"[object] (ErrorException(code: 0): Undefined index: type at /app/vendor/botman/driver-facebook/src/FacebookAudioDriver.php:24)
local.ERROR: Undefined index: type {"exception":"[object] (ErrorException(code: 0): Undefined index: type at /app/vendor/botman/driver-facebook/src/FacebookImageDriver.php:24)
local.ERROR: Undefined index: type {"exception":"[object] (ErrorException(code: 0): Undefined index: type at /app/vendor/botman/driver-facebook/src/FacebookLocationDriver.php:24)

This PR resolves this issue by first checking for the existence of the type key.

codecov[bot] commented 6 years ago

Codecov Report

Merging #55 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage     71.85%   71.85%           
- Complexity      346      358   +12     
=========================================
  Files            32       32           
  Lines           867      867           
=========================================
  Hits            623      623           
  Misses          244      244
Impacted Files Coverage Δ Complexity Δ
src/FacebookFileDriver.php 81.81% <100%> (ø) 23 <0> (+3) :arrow_up:
src/FacebookAudioDriver.php 81.81% <100%> (ø) 23 <0> (+3) :arrow_up:
src/FacebookImageDriver.php 81.81% <100%> (ø) 23 <0> (+3) :arrow_up:
src/FacebookLocationDriver.php 81.25% <100%> (ø) 22 <0> (+3) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e1ef5d...76bb4c5. Read the comment docs.