search

botman / driver-facebook

BotMan Facebook Messenger Driver
MIT License
71 stars 72 forks source link

fix trying to access offset 0 on type null #99

Closed apreiml closed 4 years ago

apreiml commented 5 years ago

fixes https://github.com/botman/driver-facebook/issues/98

codecov[bot] commented 5 years ago

Codecov Report

Merging #99 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #99   +/-   ##
========================================
  Coverage      71.4%   71.4%           
  Complexity      479     479           
========================================
  Files            50      50           
  Lines          1336    1336           
========================================
  Hits            954     954           
  Misses          382     382
Impacted Files Coverage Δ Complexity Δ
src/FacebookDriver.php 84.37% <100%> (ø) 75 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a02096c...129af86. Read the comment docs.

stefro commented 4 years ago

+1 on this PR.

vesper8 commented 4 years ago

@mpociot could you please merge this to make this driver compatible with PHP 7.4?

Fuhrmann commented 4 years ago

Could this be merged?

gurukota commented 4 years ago

They haven't accepted the pull request

On Mon, Jun 15, 2020 at 12:50 AM Ricardo Fuhrmann notifications@github.com wrote:

Could this be merged?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/botman/driver-facebook/pull/99#issuecomment-643832779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHYDMNYPTHSNSHMRC7MQG6LRWVH2NANCNFSM4JTSF6EA .

feralheart commented 4 years ago

Hi @apreiml, Thank you for your contribution

gurukota commented 4 years ago

Hi @mpociot I'm still having trouble installing the facebook driver