Closed jaewun closed 7 years ago
Merging #20 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #20 +/- ##
=========================================
Coverage 86.08% 86.08%
- Complexity 87 89 +2
=========================================
Files 8 8
Lines 273 273
=========================================
Hits 235 235
Misses 38 38
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/TelegramVideoDriver.php | 92% <100%> (ø) |
11 <0> (+2) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b3f2c86...0ff7e32. Read the comment docs.
Thank you! The existing tests only checked for the presence of video
not video_note
, so I added two more tests. Great job! :)
Hi there,
It would be great if the library treated video notes as videos. These are the quick-send videos that you can send by holding the camera button in Telegram. Super useful for quick video updates etc.
These proposed changes appear to work and all tests are passing, I believe these changes are covered by existing tests - this is my first day working with BotMan (great work by the way it's fantastic!) - so I'm not entirely sure if I'm missing anything.
Hope you find it satisfactory.
Cheers, Luke