Closed feralheart closed 2 months ago
Merging #35 into master will decrease coverage by
3.2%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #35 +/- ##
============================================
- Coverage 77.68% 74.48% -3.21%
- Complexity 116 121 +5
============================================
Files 11 11
Lines 372 388 +16
============================================
Hits 289 289
- Misses 83 99 +16
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/TelegramDriver.php | 84.88% <0%> (-8.71%) |
50 <5> (+5) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 45ed1e8...759da85. Read the comment docs.
@feralheart Thank you for the PR. Hm I wonder if we should add this to the Telegram User object.
@mpociot You're welcome. I thinked about it, too, but I didn't want to break the getUser
method.
I don't think that we break it. The Telegram driver already has a custom user object that gets returned: https://github.com/botman/driver-telegram/blob/master/src/Extensions/User.php So we could add a setter / getter for the image and pass the image to the object when it gets created.
It's a good idea. I will do it :)
@mpociot so? Merge maybe?
@feralheart any upd?
Move this to the User object, replace the env() call with $this->config() and I'll approve it.
I made these changes for the Issue #33 Documentation: