botman / driver-telegram

BotMan Telegram Driver
MIT License
87 stars 75 forks source link

add getUserProfilePhotos method #35

Closed feralheart closed 2 months ago

feralheart commented 6 years ago

I made these changes for the Issue #33 Documentation:

codecov[bot] commented 6 years ago

Codecov Report

Merging #35 into master will decrease coverage by 3.2%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
- Coverage     77.68%   74.48%   -3.21%     
- Complexity      116      121       +5     
============================================
  Files            11       11              
  Lines           372      388      +16     
============================================
  Hits            289      289              
- Misses           83       99      +16
Impacted Files Coverage Δ Complexity Δ
src/TelegramDriver.php 84.88% <0%> (-8.71%) 50 <5> (+5)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45ed1e8...759da85. Read the comment docs.

mpociot commented 6 years ago

@feralheart Thank you for the PR. Hm I wonder if we should add this to the Telegram User object.

feralheart commented 6 years ago

@mpociot You're welcome. I thinked about it, too, but I didn't want to break the getUser method.

mpociot commented 6 years ago

I don't think that we break it. The Telegram driver already has a custom user object that gets returned: https://github.com/botman/driver-telegram/blob/master/src/Extensions/User.php So we could add a setter / getter for the image and pass the image to the object when it gets created.

feralheart commented 6 years ago

It's a good idea. I will do it :)

antimech commented 5 years ago

@mpociot so? Merge maybe?

antimech commented 5 years ago

@feralheart any upd?

filippotoso commented 2 months ago

Move this to the User object, replace the env() call with $this->config() and I'll approve it.