search

botman / driver-telegram

BotMan Telegram Driver
MIT License
87 stars 75 forks source link

Don't remove inline keyboard automatically (Closes #44, closes #29, closes botman/botman#709) #48

Closed kubk closed 4 years ago

kubk commented 6 years ago

Implemented without BC break.

44

29

botman/botman#709

codecov[bot] commented 6 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
+ Coverage      76.2%   76.26%   +0.06%     
- Complexity      117      118       +1     
============================================
  Files            11       11              
  Lines           374      375       +1     
============================================
+ Hits            285      286       +1     
  Misses           89       89
Impacted Files Coverage Δ Complexity Δ
src/TelegramDriver.php 93.46% <100%> (+0.04%) 45 <0> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32ed131...ee13f3f. Read the comment docs.

sgomez commented 6 years ago

I think the right behaviour is to send an answerCallbackQuery request.

antimech commented 5 years ago

Why is it still not merged? So useful feature!

antimech commented 5 years ago

@mpociot @sschlein

antimech commented 5 years ago

@christophrumpel

feralheart commented 4 years ago

Hi, Thank you for your contribution Closes #44 closes #29 closes botman/botman#709