search

botman / driver-telegram

BotMan Telegram Driver
MIT License
87 stars 75 forks source link

Fix bug and failing tests in sendContact #71

Closed sh41 closed 4 years ago

sh41 commented 4 years ago

Hi again,

There was a missing use statement for Contact and it was sending the vcard parameter even when there was no vcard set. I've fixed the code and added a test for the vcard variation.

All the best

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5ced159). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #71   +/-   ##
========================================
  Coverage          ?   76.5%           
  Complexity        ?     119           
========================================
  Files             ?      11           
  Lines             ?     383           
  Branches          ?       0           
========================================
  Hits              ?     293           
  Misses            ?      90           
  Partials          ?       0
Impacted Files Coverage Δ Complexity Δ
src/TelegramDriver.php 93.75% <100%> (ø) 46 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ced159...2d7ac8b. Read the comment docs.

feralheart commented 4 years ago

Hi @sh41, Thank you for your contribution