search

botmasterai / botmaster-socket.io

The socket.io Botmaster integration
MIT License
8 stars 8 forks source link

added an option to use namespaced instances of socket.io directly #4

Open oneto018 opened 7 years ago

oneto018 commented 7 years ago

With this merge, it would be possible to use single instance of socket.io with multiple chatbots with namespacing option from socket.io. Basically this allows optional setting (in place of server) socket_io. Thats supposed to be an instance of socket.io or namespaced instance https://socket.io/docs/rooms-and-namespaces/#custom-namespaces

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-6.06%) to 93.939% when pulling 147db68333df0e2d1f3c12c4feaa2cdbc62ba826 on oneto018:master into c3c32d0bce2410c1df483c2c528af9ac57e9ce6b on botmasterai:master.

jdwuarin commented 7 years ago

Hi @oneto018, Thanks for the pull request. Will need to make sure to test that code before I can merge the request.

When doing so, make sure that the tests pass for not only having a scoped namespace per SocketioBot instance, but also within said namespace, using "botmasterUserId" and what happens when the same botmasterUserId is used accross two different namespaces. Really answering the question what should happen in such cases.

exsesx commented 5 years ago

Any updates?

nagarajanSnapwiz commented 5 years ago

I am sorry! I completely forgot about this. If this feature is something others interested in, I will write the tests when I have time