'next' and 'prev' skip a page when using href-option

botmonster / jquery-bootpag

BootPag - boostrap dynamic pagination jQuery plugin

MIT License

525 stars 263 forks source link

'next' and 'prev' skip a page when using href-option #19

Closed gvanderploeg closed 9 years ago

gvanderploeg commented 10 years ago

When clicking the next- or prev-button combined with the use of the custom href-option, the {{number}} in the href will skip a page. When beginning on page 1, clicking on 'next' will have these effects:

page 2 in the pager is highlighted as the current (expected)
but the browser URL will have changed to #page-3 (or ?page=3, whatever actual href-option was configured) (unexpected)

Same goes for the 'prev' button.

Example with debug logging in JS Fiddle: http://jsfiddle.net/SuUZ6/

catsncode commented 10 years ago

I am stuck on this issue as well. Does anyone have a work around or a fix? Thanks!

gvanderploeg commented 10 years ago

We worked around it by using the 'page' event instead of the href-option. In the page-event we just set window.location using the 'num' parameter (which is correct there and does not skip a page)

catsncode commented 10 years ago

Thanks for the tip! I did find how to fix the javascript, but I'm not sure if it might break something else. So far it is working well.

me.find('li').click(function paginationClick(){ var me = $(this); if(me.hasClass('disabled')){ return; } var page = parseInt(me.attr('data-lp'), 10); /////renderPage($bootpag, page); /* was causing the skip */ $owner.trigger('page', page); });