boto / boto3

AWS SDK for Python
https://aws.amazon.com/sdk-for-python/
Apache License 2.0
9.06k stars 1.87k forks source link

association.gateway-id filter parameter is missing in https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/describe_route_tables.html #3974

Closed Yatin03 closed 10 months ago

Yatin03 commented 10 months ago

Describe the issue

association.gateway-id filter parameter is missing in https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/describe_route_tables.html.

Links

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/describe_route_tables.html

Yatin03 commented 10 months ago

I would like to know where I can make changes and raise a pull request.

RyanFitzSimmonsAK commented 10 months ago

Hi @Yatin03, thanks for reaching out. I'm not seeing association.gateway-id as an available filter for this operation in the API reference guide. Are route.nat-gateway-id or route.transit-gateway-id not what you're looking for?. If another SDK does support filtering on association.gateway-id, please point me towards it. If not, I can forward this to the service team as a feature request.

On the topic of contributing to the repository, I'd recommend reading the contribution guide. However, because filter parameters are provided by the service team, you won't be able to make this particular change happen through a pull request.

Hope that helps!

Yatin03 commented 10 months ago

Hi @RyanFitzSimmonsAK,

association.gateway-id filter is supported but not documented. So, i want to add in document. Sample Code: `import boto3

ec2 = boto3.resource('ec2') client = boto3.client('ec2')

response = client.describe_route_tables( Filters=[ { 'Name': 'association.gateway-id', 'Values': ["igw-****"] } ] )

print(json.dumps(response, indent=2))

print(response["RouteTables"][0]["RouteTableId"])`

RyanFitzSimmonsAK commented 10 months ago

Thanks for clarifying, I was able to reproduce this. As this is a service team issue, I've reached out to the EC2 team about making this change to the documentation. In the meantime, I'm going to create a tracking issue in our cross-SDK repository (https://github.com/aws/aws-sdk/issues/666). I'll leave any updates in the new issue. Thanks!

github-actions[bot] commented 10 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.