search

boto / botocore

The low-level, core functionality of boto3 and the AWS CLI.
Apache License 2.0
1.44k stars 1.06k forks source link

Support for SOCKS5 proxies #2540

Open acdha opened 2 years ago

acdha commented 2 years ago

880 was closed without resolution. We use this feature to run AWS clients using an SSH dynamic proxy — the lower-level libraries support this but botocore's httpsession code assumes an HTTP proxy as described in that issue. #2081 has a patch which will resolve this but it needs a few improvements to fix it.

stobrien89 commented 2 years ago

Hi @acdha,

Thanks for the feature request! I've seen this come up a few times and I'm surprised we don't already have an open feature request for this. For purposes of prioritization, we'll leave this open to see how much traction it gets. Anyone interested in this feature: please leave a (preferably positive) reaction on the original post.

zhan9san commented 2 years ago

@acdha and @stobrien89

Could you please verify whether #2541 fixes this issue?

acdha commented 2 years ago

@zhan9san In limited testing, this seems to be working — I ran curl -fs https://patch-diff.githubusercontent.com/raw/boto/botocore/pull/2541.diff | patch --strip=1 against the the site-packages directory in my venv and was able to use a proxy seamlessly.

rhysjtevans commented 2 years ago

Any progress on this chaps?

derrix060 commented 1 year ago

This would be much appreciated, and it seems there are a lot of people wanting the feature as well

derrix060 commented 1 year ago

BTW This patch is working fine: https://github.com/boto/botocore/pull/2541

lionbee commented 1 year ago

We have a couple of patches from different people which could solve this problem. Is there anything we can do to move this forward?

paulwouters commented 1 year ago

We keep porting the socks support to new versions, and it is becoming rather annoying, but also sad. So many people keep asking for this. So if @stobrien89 can try and merge this, that would be appreciated.

fingon commented 3 months ago

https://github.com/boto/botocore/pull/2541 was now closed too. I guess there is no light at end of this particular tunnel (which is unfortunate, as in some deployments direct calls are not an option).