search

boto / botocore

The low-level, core functionality of boto3 and the AWS CLI.
Apache License 2.0
1.44k stars 1.06k forks source link

Fix pytest-8.0.0 test failures due to incorrect `pytest.warns()` #3109

Closed mgorny closed 4 months ago

mgorny commented 5 months ago

Remove two incorrect pytest.warns() invocations for .get_component('internal'), in order to fix test failures with pytest 8.0.0. This version of pytest fixes pytest.warns() to work inside pytest.raises(), and therefore causes the tests to fail because the warning is not emitted when get_component() raises ValueError.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (03891ec) 93.14% compared to head (cf536ce) 93.14%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3109 +/- ## ======================================== Coverage 93.14% 93.14% ======================================== Files 66 66 Lines 14237 14237 ======================================== Hits 13261 13261 Misses 976 976 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgorny commented 4 months ago

Thanks!