Support urllib3 2.1.0 and 2.2.0 to be installed

matejsp commented 4 months ago

Describe the feature

There is a new version of urllib3 (v2.2.0, v2.1.9) that can't be installed in projects that use botocore because, in the setup.py file, it has the version restriction:

urllib3>=1.25.4,<2.1; python_version>="3.10"

Use Case

urllib3 getting http/2 support (basic for now).

Proposed Solution

No response

Other Information

No response

Acknowledgements

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

SDK version used

1.34.34

Environment details (OS name and version, etc.)

MacOSX Sonoma

RyanFitzSimmonsAK commented 4 months ago

Hi @iherasymenko, thanks for reaching out. According to the main tracking thread for the urllib3 pin, urllib3 2.1.x+ contains several breaking changes.

https://github.com/boto/botocore/issues/2926#issuecomment-1753332063

We're currently pinned at urllib3<2.1 since it will contain a handful of breaking changes.

I'm going to close this issue as a duplicate in favor of the main tracking thread, which you can refer to for any updates regarding the urllib3 pin.

github-actions[bot] commented 4 months ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.

boto / botocore