search

boto / botocore

The low-level, core functionality of boto3 and the AWS CLI.
Apache License 2.0
1.44k stars 1.06k forks source link

Relax urllib3 upper bound #3122

Closed NickCrews closed 4 months ago

NickCrews commented 4 months ago

Describe the bug

I am getting dependency conflicts due to the upper bound of urllib3<2.1 for python_version>="3.10". Unless we KNOW that botocore doesn't work with urllib3>=2.1, can we remove this restriction?

this dep constraint was most recently changed in https://github.com/boto/botocore/pull/3034. I read through there and didn't see anything there about why the upper bound was included, but there might be a good reason.

Expected Behavior

I can co-install another package that requires urllib>=2.1

Current Behavior

I can't install that other package.

Reproduction Steps

NA

Possible Solution

No response

Additional Information/Context

No response

SDK version used

main

Environment details (OS name and version, etc.)

NA

nateprewitt commented 4 months ago

Hi @NickCrews,

The reason we currently have the upperbound is due to urllib3's breaking changes in 2.1.0 as announced by urllib3 here. There are also other regressions in 2.2.0 that are breaking for botocore that are being tracked in https://github.com/urllib3/urllib3/issues/3343.

For that reason, we can't move the pin without breaking the majority of botocore users without them taking manual steps to include the pin themselves.

NickCrews commented 4 months ago

Wow, yeah that is a lot of unhappy people in https://github.com/boto/botocore/issues/3111. This makes sense, thank you!

github-actions[bot] commented 4 months ago

This issue is now closed. Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one.