search

boto / s3transfer

Amazon S3 Transfer Manager for Python
Apache License 2.0
209 stars 133 forks source link

Add Python 3.8 to Travis #162

Closed gliptak closed 4 years ago

gliptak commented 4 years ago

The https://travis-ci.org/boto/s3transfer/jobs/653864672 fails with

======================================================================

FAIL: test_download_futures_fail_triggers_shutdown (tests.unit.test_s3transfer.TestMultipartDownloader)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/boto/s3transfer/tests/unit/test_s3transfer.py", line 484, in test_download_futures_fail_triggers_shutdown

    downloader.download_file('bucket', 'key', 'filename',

AssertionError: "fake download parts error" does not match "FINISHED: <Future at 0x7fd9b8c8b2e0 state=finished returned NoneType>"

-------------------- >> begin captured logging << --------------------

s3transfer: DEBUG: Making get_object call.

s3transfer: DEBUG: EXITING _download_range for part: 0

--------------------- >> end captured logging << ---------------------

Possibly pointing out a race condition at https://github.com/boto/s3transfer/blob/develop/s3transfer/__init__.py#L490 ?

gliptak commented 4 years ago

https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.wait