boto / s3transfer

Amazon S3 Transfer Manager for Python
Apache License 2.0
215 stars 134 forks source link

Add user provided SSE-C arguments to CompleteMultipartUpload call #274

Closed nateprewitt closed 1 year ago

nateprewitt commented 1 year ago

This PR will forward SSE-C arguments provided by the user to the final CompleteMultipartUpload call to handle cases where a policy has been defined which requires these for all PutObject calls.

This is to resolve a recently published workflow by S3 which changed the requiredness of these arguments due to PutObject being used under the hood for CompleteMultipartUpload.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% :tada:

Comparison is base (a90891c) 85.39% compared to head (96de9f0) 85.54%. Report is 5 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #274 +/- ## =========================================== + Coverage 85.39% 85.54% +0.14% =========================================== Files 16 16 Lines 2719 2719 =========================================== + Hits 2322 2326 +4 + Misses 397 393 -4 ``` | [Files Changed](https://app.codecov.io/gh/boto/s3transfer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boto) | Coverage Δ | | |---|---|---| | [s3transfer/copies.py](https://app.codecov.io/gh/boto/s3transfer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boto#diff-czN0cmFuc2Zlci9jb3BpZXMucHk=) | `100.00% <100.00%> (ø)` | | | [s3transfer/upload.py](https://app.codecov.io/gh/boto/s3transfer/pull/274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boto#diff-czN0cmFuc2Zlci91cGxvYWQucHk=) | `96.38% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/boto/s3transfer/pull/274/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boto)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.