search

boto / s3transfer

Amazon S3 Transfer Manager for Python
Apache License 2.0
215 stars 134 forks source link

Turn on checksum validation for CRT S3 transfer manager #280

Closed kyleknap closed 1 year ago

kyleknap commented 1 year ago

For uploads, the CRT S3 client will add CRC32 trailing checksums. For downloads, the CRT S3 client will validate checksums associated to the object when possible.

This is a port from this CLI v2 PR: https://github.com/aws/aws-cli/pull/8298

codecov-commenter commented 1 year ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (b8906b3) 84.97% compared to head (d85a0fa) 84.57%.

Files Patch % Lines
s3transfer/crt.py 0.00% 13 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## crt-enhancements #280 +/- ## ==================================================== - Coverage 84.97% 84.57% -0.41% ==================================================== Files 16 16 Lines 2736 2749 +13 ==================================================== Hits 2325 2325 - Misses 411 424 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.