boto / s3transfer

Amazon S3 Transfer Manager for Python
Apache License 2.0
209 stars 133 forks source link

Update throughput target defaults #282

Closed kyleknap closed 10 months ago

kyleknap commented 10 months ago

Instead of defaulting to five gigabits per second when no target throughput is configured, s3transfer will use the CRT to determine if there is a recommended target throughput to use. If it is unable, to determine a recommended target throughput, it will default to ten gigabits per second, which is the current throughput default for the CRT S3 client.

This behavior was updated to help minimize the amount of configuration required to get the fastest throughputs from the CRT transfer client. The fallback throughput was updated from five to ten gigabits so that the CRT S3 integration is consistent with the underlying CRT S3 client's defaults.

This a port of this AWS CLI v2 PR: https://github.com/aws/aws-cli/pull/8327/

codecov-commenter commented 10 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (f9e71b2) 84.12% compared to head (4bd8046) 83.85%.

Files Patch % Lines
s3transfer/crt.py 0.00% 12 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## crt-enhancements #282 +/- ## ==================================================== - Coverage 84.12% 83.85% -0.28% ==================================================== Files 16 16 Lines 2759 2768 +9 ==================================================== Hits 2321 2321 - Misses 438 447 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.