boto / s3transfer

Amazon S3 Transfer Manager for Python
Apache License 2.0
215 stars 134 forks source link

Add monthly download badge to README #305

Closed ayushjain01 closed 4 months ago

ixmatus commented 5 months ago

A colleague of this person tried to open this exact PR against a project I'm the maintainer for as well (https://github.com/ixmatus/inflector/pull/16). This is a promotional campaign and they (or colleagues) appear to be doing it on reddit too, I think this is suspicious activity. They are creating an external dependency on a web property that (as far as I can tell) is not officially blessed by pypi. I recommend rejecting this PR.

Users can get package statistics from libraries.io which is linked to directly by pypi itself.

ayushjain01 commented 4 months ago

Thank you for your feedback and concerns. I'd like to clarify that this is not a promotional campaign. As stated in the PR description, our intention is simply to share a tool we have developed, which we believe could be beneficial to the community.

Our badge system offers highly accurate statistics, which is why we wanted to make it available. If the link to the pip trends page is a concern, we are more than willing to remove it.

We respect your decision if you prefer not to add more badges to your README. Our primary goal is to address any misunderstandings and assure you that this is a genuine effort to contribute to the open-source community by sharing our work on GitHub.

Thank you for considering our contribution.

nateprewitt commented 4 months ago

Thanks for the PR! Unfortunately, I don't think this is something we'll be adding at this time.