search

botobag / artemis

GraphQL implementation for Go
Other
10 stars 0 forks source link

[future] Fix Join. #120

Closed zonr closed 5 years ago

zonr commented 5 years ago

We have to create a custom waker to poll each future inside a join. The waker passed to the future returned by Join must only be called when all of the passed-in futures complete or one of them returns an error.

codecov[bot] commented 5 years ago

Codecov Report

Merging #120 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage    73.6%   73.65%   +0.04%     
==========================================
  Files          66       66              
  Lines        6873     6893      +20     
==========================================
+ Hits         5059     5077      +18     
- Misses       1546     1547       +1     
- Partials      268      269       +1
Impacted Files Coverage Δ
concurrent/future/join.go 100% <100%> (ø) :arrow_up:
concurrent/worker_pool_executor.go 88.31% <0%> (-0.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37be612...edf1b72. Read the comment docs.

zonr commented 5 years ago

This fixed https://circleci.com/gh/botobag/artemis/839.