search

botobag / artemis

GraphQL implementation for Go
Other
10 stars 0 forks source link

[handler] Handler makes set up GraphQL services easily. #146

Closed zonr closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #146 into master will decrease coverage by 1.92%. The diff coverage is 38.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   74.86%   72.93%   -1.93%     
==========================================
  Files          72       77       +5     
  Lines        7502     7922     +420     
==========================================
+ Hits         5616     5778     +162     
- Misses       1580     1819     +239     
- Partials      306      325      +19
Impacted Files Coverage Δ
graphql/handler/error_presenter.go 0% <0%> (ø)
graphql/handler/low_level_handler.go 23.94% <23.94%> (ø)
graphql/handler/parse_http_request.go 25% <25%> (ø)
graphql/handler/operation_cache.go 45.6% <45.6%> (ø)
graphql/handler/http_handler.go 57.4% <57.4%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2bc751a...145d5bc. Read the comment docs.

zonr commented 5 years ago

The changes pushes performance results of travelgatex benchmark further by introducing a cache (i.e., handler.OperationCache) to save parsing efforts for repeated requests. I want to merge the changes first to publish the benchmark results and will improve the test coverage later.