Closed allardy closed 1 year ago
Adding tests for that function would be pretty easy. Should we do this now?
Agreed that tests would be nice, but i'm not really used to DOM testing. Could be a good challenge for someone who implements new features in the future
I was not thinking of DOM testing, but only testing some functions of inject.ts file. Here, the isWebchatEvent()
could benefit from a few simple tests
@spg Tests added.
I disabled the firefox test because it's broken and has been for a long time, 6h running time is abusive. Fixing the real error should be done in a sepatate pr
@allardy please add a ticket in Linear so we remember to fix the tests
Pretty sure the error is related to the "isWebchatEvent" function... It was really too basic.![image](https://user-images.githubusercontent.com/42552874/199657284-b29274b3-7cf8-4509-a4d5-4690e82e07d1.png)
These event causes those errors:![image](https://user-images.githubusercontent.com/42552874/199657406-aa4c5a97-f245-4385-b857-56dfa858acf9.png)
Still need a way to test them correctly, since stratus uses the CDN, I didn't test "strictly", but logic looks fine.