fix(socket): don't send userdata=undefined - Githubissues

botpress / messaging

Botpress messaging server

41 stars 37 forks source link

fix(socket): don't send userdata=undefined #582

Closed spg closed 1 year ago

spg commented 1 year ago

Fixes an issue where sending ?userData=undefined was being sent when opening the socket. This results in unexpected user updates here https://github.com/botpress/messaging/blob/cae0d2dc0e366a2708a1e4704f4d16a3956e9c56/packages/server/src/socket/manager.ts#L108

because _.isEqual('undefined', undefined) === false