botpress / modules

MOVING TO BOTPRESS/BOTPRESS, branch `develop/x`, folder "packages"
GNU Affero General Public License v3.0
23 stars 29 forks source link

Fix HITL reading session ID after insert #22

Closed djanowski closed 6 years ago

djanowski commented 6 years ago

This is more evident when running under Postgres, because the following query trying to bind session.id (undefined) fails.

Tested on both Postgres and SQLite.

slvnperron commented 6 years ago

@djanowski Hey, thanks very much for the fix. Any chance you could make this on botpress/botpress towards the develop/x branch instead? We're moving to a mono-repo

Thanks

djanowski commented 6 years ago

Yeah sorry, I missed that I was creating the PR against master.

djanowski commented 6 years ago

Wait, I thought this was the monorepo (for modules). I didn't know everything was being moved to botpress/botpress.

djanowski commented 6 years ago

https://github.com/botpress/botpress/pull/547