search

botpress / modules

MOVING TO BOTPRESS/BOTPRESS, branch `develop/x`, folder "packages"
GNU Affero General Public License v3.0
23 stars 29 forks source link

[style] Add eslint rules for easier contribution #5

Open mrbarletta opened 6 years ago

mrbarletta commented 6 years ago

Hey team, botpress has linting rules .eslintrc and some scripts defined in package.json that makes contributing and styling a lot easier :)

I tried to copy those to botpress-modules and there are a lot of changes to do to comply with the same rules defined for botpress.

Should I do a PR adding the same .eslintrc found in botpress + the recommended fixes?

slvnperron commented 6 years ago

Hey! That's something that I wanted to do forever and having the monorepo will help so much, as all repos will point to the root .eslintrc file!

I think two separate PRs would be best, the addition big the files will be merged instantly whereas the other PR will require me to compile & test all modules individually.

Thanks!!

On Fri, Mar 16, 2018, 7:22 PM Matias Barletta notifications@github.com wrote:

Hey team, botpress has linting rules .eslintrc and some scripts defined in package.json that makes contributing and styling a lot easier :)

I tried to copy those to botpress-modules and there are a lot of changes to do to comply with the same rules defined for botpress.

Should I do a PR adding the same .eslintrc found in botpress + the recommended fixes?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/botpress/modules/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQStDcuUQLK7i1h6zA5dzVN1KxkdESxks5tfEkpgaJpZM4Sujt5 .

slvnperron commented 6 years ago

Also note that having prettier setup here would make your life much easier, as you can run a single command to restructure all files.

On Fri, Mar 16, 2018, 7:41 PM Sylvain Perron sylvain@botpress.io wrote:

Hey! That's something that I wanted to do forever and having the monorepo will help so much, as all repos will point to the root .eslintrc file!

I think two separate PRs would be best, the addition big the files will be merged instantly whereas the other PR will require me to compile & test all modules individually.

Thanks!!

On Fri, Mar 16, 2018, 7:22 PM Matias Barletta notifications@github.com wrote:

Hey team, botpress has linting rules .eslintrc and some scripts defined in package.json that makes contributing and styling a lot easier :)

I tried to copy those to botpress-modules and there are a lot of changes to do to comply with the same rules defined for botpress.

Should I do a PR adding the same .eslintrc found in botpress + the recommended fixes?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/botpress/modules/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQStDcuUQLK7i1h6zA5dzVN1KxkdESxks5tfEkpgaJpZM4Sujt5 .